[release/11.0] Disable ConnectAsync_WithBuffer_Succeeds test on all platforms - #134047
Merged
svick merged 1 commit intoSep 17, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Scope the quarantine to the affected platform before approval.
Pull request overview
Updates the release/11.0 socket test quarantine for a known intermittent buffered-connect failure.
Changes:
- Widens
ActiveIssue#133012 from Android-only to all Unix platforms. - No runtime logic changes.
File summaries
| File | Summary |
|---|---|
src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.Unix.cs |
The issue should be scoped to Linux to preserve unrelated Apple, Android, and BSD coverage. |
Review details
Suppressed comments (1)
src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.Unix.cs:196
- With no
TestPlatformsargument, thisActiveIssueskips the test on every target that compilesConnect.Unix.cs, including Apple, Android, and BSD targets. Issue #133012 reports failures only on Linux, while this test deliberately covers distinct Apple/Android TFO behavior on lines 224-235, so this removes unrelated cross-platform coverage. Please scope #133012 to Linux and retain the existing Android skip unless there is evidence that the release branch fails on every Unix target.
[ActiveIssue("https://github.com/dotnet/runtime/issues/133012")]
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
ManickaP
approved these changes
Sep 16, 2026
Member
Author
|
/ba-g Test failure is unrelated to disabled test |
Member
Author
|
Test only change => tell mode, approved by Karel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen the ActiveIssue to de-noise CI runs
Related to #133012
The bug is fixed in main by https://github.com/dotnet/runtime/pull/133201/changes