[mono][interp] Add nullcheck when constant folding vt.GetType - #134095
Merged
Merged
Conversation
The valuetype pointer can still be null, in which case we need to throw NRE.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @vitek-karas, @BrzVlad, @kotlarmilos |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The null check is added while preserving the existing optimization.
Pull request overview
Fixes Mono interpreter GetType() behavior by throwing NullReferenceException for null value-type pointers during constant folding.
Changes:
- Emits
MINT_CKNULLbefore loading the constant runtime type. - Preserves constant folding for valid pointers.
File summaries
| File | Description |
|---|---|
src/mono/mono/mini/interp/transform.c |
Adds the required null check during GetType() folding. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
lewing
approved these changes
Sep 16, 2026
BrzVlad
enabled auto-merge (squash)
September 16, 2026 20:57
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 18, 2026
…#134095) The valuetype pointer can still be null, in which case we need to throw NRE. Fixes dotnet#133992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The valuetype pointer can still be null, in which case we need to throw NRE.
Fixes #133992