Make sure the interpreter code is published before the native code for a method - #134137
Merged
Merged
Conversation
…r a method Consider the scenario if the precode is patched before publishing the interpreter code to the MethodDesc. If the precode is not pointing to the prestub, in `PrepareInterpreterCode` we would no longer enter `DoPrestub` then we might observe that the interpreter code is still null, in which case we poison it. When the thread that was doing the compilation tries now to publish the interpreter code, it will encounter the poisoned value and assert.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified; only a minor comment cleanup was noted.
Pull request overview
This pull request fixes interpreter-code publication ordering to prevent races during prestub setup.
Changes:
- Publishes interpreter code before redirecting the precode.
- Reads interpreter data directly from the generated stub.
- Documents the required ordering.
File summaries
| File | Summary |
|---|---|
src/coreclr/vm/prestub.cpp |
Fixes interpreter-code publication ordering. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Correct comment duplication in prestub.cpp Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
janvorli
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the scenario if the precode is patched before publishing the interpreter code to the
MethodDesc. If the precode is not pointing to the prestub, inPrepareInterpreterCodewe would no longer enterDoPrestubthen we might observe that the interpreter code is still null, in which case we poison it. When the thread that was doing the compilation tries now to publish the interpreter code, it will encounter the poisoned value and assert.This ordering was enforced in other places, in #130026, but this path was missed. This failure started happening on the new interpreter libraries pipeline that disables jit since there we end up interpreting some stubs.
Fixes #133771