Fix XARCH importation of isPositive and isNegative - #134151
Merged
Merged
Conversation
dhartglassMSFT
requested review from
tannergooding
and
a lite review from Copilot
and removed request for
Copilot
September 17, 2026 19:06
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
approved these changes
Sep 17, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for 256-bit floating-point sign checks with AVX2 disabled.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes JIT importation of 256-bit vector IsPositive and IsNegative when AVX2 is disabled.
Changes:
- Requires AVX2 for signed integer and floating-point sign checks.
- Preserves AVX-only handling for unsigned vectors and
Vector.Abs.
File summaries
| File | Description |
|---|---|
src/coreclr/jit/hwintrinsic.cpp |
Updates AVX2 capability detection for vector sign checks. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
tannergooding
approved these changes
Sep 17, 2026
dhartglassMSFT
enabled auto-merge (squash)
September 17, 2026 23:35
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIT expansion of 256b vector floating point
IsNegativeandIsPositiverequires AVX2. Checking withvarTypeIsSignedsilently let these through when EnableAVX2=0.fixes #134150