[cDAC] Export interpreter JIT manager descriptor - #134190
max-charlamb merged 1 commit into
Conversation
Publish the optional InterpreterJitManagerAddress global so .NET 11 runtimes contain the descriptor needed by the managed cDAC reader support in dotnet#134072. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b507532c-3857-4e61-86a9-69fe22ec157b
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
1 similar comment
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, feature-gated addition that follows the existing cDAC global-pointer export pattern and should not affect non-interpreter builds.
Pull request overview
This PR adds a new optional cDAC data-descriptor global that exposes the address of ExecutionManager::m_pInterpreterJitManager when CoreCLR is built with FEATURE_INTERPRETER, enabling external consumers to discover the interpreter JIT manager via the data descriptor.
Changes:
- Add
InterpreterJitManagerAddressas aCDAC_GLOBAL_POINTERguarded byFEATURE_INTERPRETER. - Extend
cdac_data<ExecutionManager>to provide the address ofExecutionManager::m_pInterpreterJitManagerunder the same feature guard.
File summaries
| File | Description |
|---|---|
| src/coreclr/vm/datadescriptor/datadescriptor.inc | Exports the new optional InterpreterJitManagerAddress global pointer when FEATURE_INTERPRETER is enabled. |
| src/coreclr/vm/codeman.h | Defines the cdac_data<ExecutionManager>::InterpreterJitManagerAddress pointer source (address of ExecutionManager::m_pInterpreterJitManager) under FEATURE_INTERPRETER. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
|
/ba-g macOS timeout |
|
/backport to release/11.0 |
|
Started backporting to |
Expose
ExecutionManager::m_pInterpreterJitManageras the optionalInterpreterJitManagerAddresscDAC data-descriptor global when CoreCLR is built withFEATURE_INTERPRETER.Will be used by #134072 for cDAC dump enumeration.