Add Composite ML-KEM certificate key accessors - #134259
Merged
PranavSenthilnathan merged 1 commit intoSep 19, 2026
Merged
PranavSenthilnathan merged 1 commit into
PranavSenthilnathan merged 1 commit into
Conversation
Add public-key extraction and validated PlatformNotSupportedException private-key retrieval and copy APIs to System.Security.Cryptography and Microsoft.Bcl.Cryptography, matching Composite ML-DSA conventions. AI-assisted change generated with GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7e308cd1-67b1-4bd6-a16d-2cada6f92de8
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds experimental Composite ML-KEM certificate key accessors, following the existing Composite ML-DSA pattern.
Changes:
- Adds
X509Certificate2accessors and private-key association stub. - Adds Microsoft.Bcl.Cryptography compatibility extensions.
- Updates the reference API.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs | Updated as part of this pull request. |
| src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs | Updated as part of this pull request. |
| src/libraries/Microsoft.Bcl.Cryptography/src/System/Security/Cryptography/X509Certificates/X509CertificateKeyAccessors.cs | Updated as part of this pull request. |
bartonjs
approved these changes
Sep 19, 2026
Member
Author
|
/backport to release/11.0 |
Contributor
|
Started backporting to |
PranavSenthilnathan
deleted the
ps-composite-ml-kem-certificate-keys
branch
September 19, 2026 23:39
1 of 2 tasks
artl93
pushed a commit
that referenced
this pull request
Sep 21, 2026
Backport of #134259 to release/11.0 Add Composite ML-KEM certificate key accessors. /cc @PranavSenthilnathan ## Customer Impact New PQC API. ## Regression - [ ] Yes - [x] No ## Risk Low, new API. Co-authored-by: Pranav Senthilnathan <pranas@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7e308cd1-67b1-4bd6-a16d-2cada6f92de8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cert accessor stubs like we did for Composite ML-DSA.
I've omitted PublicKey changes but am going to mark the Composite ML-KEM API as implemented anyway (we can add it in the future if we need it):
Fixes #129633