Re-enable badcodeinsidefinally for Wasm R2R - #134288
Merged
lewing merged 2 commits intoSep 20, 2026
Merged
Conversation
Remove the issue-specific ActiveIssue attribute now that both test variants pass under browser-Wasm ReadyToRun. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9306b1e0-f7c4-451f-b8cc-0749cc39e423
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Remove the remaining unused TestLibrary project references before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Re-enables the badcodeinsidefinally test for browser-Wasm ReadyToRun.
Changes:
- Removes the Wasm quarantine metadata.
- Removes obsolete IL assembly references.
| File | Description |
|---|---|
src/tests/JIT/Methodical/eh/deadcode/badcodeinsidefinally.il |
Re-enables the test and removes obsolete references. |
Member
Author
Drop the TestLibrary project references left unused after removing the platform-specific ActiveIssue attribute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9306b1e0-f7c4-451f-b8cc-0749cc39e423
lewing
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
badcodeinsidefinallyActiveIssueattributeTesting
badcodeinsidefinally_d: printedpass, exit 100badcodeinsidefinally_r: printedpass, exit 100Resolves #133504
Note
This pull request description was generated with GitHub Copilot.