Disable badinlinee on unsupported configurations - #134309
Merged
AndyAyersMS merged 1 commit intoSep 20, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain, and all reviewers assessed it as ready.
Review effort: Lite
Findings: None
What changed in this PR
Updates the badinlinee JIT regression test to avoid unsupported configurations while preserving supported coverage.
Changes:
- Excludes browser CoreCLR.
- Marks the test incompatible with interpreter execution.
| File | Description |
|---|---|
src/tests/JIT/opt/GuardedDevirtualization/badinlinee.csproj |
Adds browser-CoreCLR exclusion and interpreter incompatibility metadata. |
Member
Author
|
@dotnet/wasm-contrib ptal |
lewing
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
badinlineeregression test requires tiered optimizing-JIT behavior to inlineBase.M()and eliminate the measured allocation. Browser CoreCLR currently relies on the interpreter for this configuration, where tiered compilation is disabled, causing the deterministic 12,000-byte allocation failure.Exclude the test only for browser CoreCLR and mark it interpreter-incompatible. This follows the existing pattern used by
ObjectStackAllocationTestswhile preserving coverage on optimizing-JIT configurations.Validation:
build.cmd clr+libs -lc release -rc checkedbadinlinee.cmdpassed with expected exit code 100_WillCLRTestProjectBuild=false_WillCLRTestProjectBuild=trueResolves #134169
Note
This pull request description was generated with GitHub Copilot.