[WIP] Fix test failure in jitstress2 JIT assert during DependencyInjection.Tests - #134311
AndyAyersMS with Copilot wants to merge 2 commits into
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: AndyAyersMS <10121823+AndyAyersMS@users.noreply.github.com>
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
I checked #134295. It has the same assertion/source location and the same async-transform phase, and one of its failures is the same I also attempted local |
|
@jakobbotsch ptal |
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The JIT transformation change warrants final human review before approval.
Review effort: Lite
Findings: None
What changed in this PR
Fixes a CoreCLR JIT profile-flag assertion during async transformation and adds targeted jitstress2 regression coverage.
Changes:
- Propagates
BBF_PROF_WEIGHTto synthesized OSR jump blocks. - Adds async regression coverage.
- Configures isolated tiered-PGO jitstress execution.
| File | Description |
|---|---|
src/tests/async/regression/134304.csproj |
Configures isolated jitstress2 execution. |
src/tests/async/regression/134304.cs |
Adds async regression coverage. |
src/coreclr/jit/async.cpp |
Propagates profile-weight metadata to generated OSR blocks. |
|
Didn't notice this. I submitted the same change with a bit more clean up in #134325. I don't think we need the test given that this is already caught in CI.. I'll close this one. |
Uh oh!
There was an error while loading. Please reload this page.