Skip to content

[WIP] Fix test failure in jitstress2 JIT assert during DependencyInjection.Tests - #134311

Closed
AndyAyersMS with Copilot wants to merge 2 commits into
mainfrom
copilot/ci-scan-fix-jitstress2-assert
Closed

AndyAyersMS with Copilot wants to merge 2 commits into
mainfrom
copilot/ci-scan-fix-jitstress2-assert

Conversation

Copilot AI commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor
  • Inspect CI context and issue details
  • Read applicable repository/JIT/native/build instructions
  • Identify likely async-transform profile flag propagation gap
  • Complete required CoreCLR baseline build before editing
  • Apply the minimal JIT fix
  • Add or run focused regression coverage for the failing DependencyInjection jitstress case
  • Run targeted build/test/format validation
  • Run secret scan and parallel validation

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Co-authored-by: AndyAyersMS <10121823+AndyAyersMS@users.noreply.github.com>
Copilot AI requested a review from AndyAyersMS September 20, 2026 16:14
@jkoritzinsky jkoritzinsky added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Infrastructure labels Sep 20, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS

Copy link
Copy Markdown
Member

@copilot see if this also fixes #134295

Copilot AI commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

@copilot see if this also fixes #134295

I checked #134295. It has the same assertion/source location and the same async-transform phase, and one of its failures is the same ServiceProviderEngineScope.DisposeAsync method, so this PR’s shared async OSR profile-flag fix should cover it as the same root cause.

I also attempted local DOTNET_JitStress=1 library smoke runs for DependencyInjection and System.Private.Xml, but this checkout’s current shared-framework/targeting-pack layout failed before test execution, so I don’t have a completed local jitstress1 library pass to cite.

@AndyAyersMS

Copy link
Copy Markdown
Member

@jakobbotsch ptal

@AndyAyersMS
AndyAyersMS marked this pull request as ready for review September 20, 2026 23:54
Copilot AI lite review requested due to automatic review settings September 20, 2026 23:54
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The JIT transformation change warrants final human review before approval.

Review effort: Lite
Findings: None

What changed in this PR

Fixes a CoreCLR JIT profile-flag assertion during async transformation and adds targeted jitstress2 regression coverage.

Changes:

  • Propagates BBF_PROF_WEIGHT to synthesized OSR jump blocks.
  • Adds async regression coverage.
  • Configures isolated tiered-PGO jitstress execution.
File Description
src/​tests/​async/​regression/​134304.csproj Configures isolated jitstress2 execution.
src/​tests/​async/​regression/​134304.cs Adds async regression coverage.
src/​coreclr/​jit/​async.cpp Propagates profile-weight metadata to generated OSR blocks.

@jakobbotsch

Copy link
Copy Markdown
Member

Didn't notice this. I submitted the same change with a bit more clean up in #134325. I don't think we need the test given that this is already caught in CI.. I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

Status: Done

5 participants