Skip to content

Move full browser CoreCLR R2R library tests to outer loop - #134357

Merged
lewing merged 2 commits into
mainfrom
lewing-wasm-r2r-smoke-lane
Sep 21, 2026
Merged

lewing merged 2 commits into
mainfrom
lewing-wasm-r2r-smoke-lane

Conversation

@lewing

@lewing lewing commented Sep 21, 2026

Copy link
Copy Markdown
Member

Summary

Follow up #133656 by moving the full trimmed browser CoreCLR ReadyToRun library-test lane out of the default runtime pipeline and into the scheduled runtime-extra-platforms pipeline.

  • Run trimmed CoreCLR ReadyToRun smoke tests in normal PR/default CI via RunSmokeTestsOnly, targeting approximately 45 minutes of build time.

  • Keep the full test selection in the scheduled outer loop; the prior full build took 3h09m after parallelization.

  • Preserve an explicit manual full run through this PR comment command:

    /azp run runtime-wasm-libtests
    

Validation

  • Parsed all three changed YAML files with PyYAML.
  • Verified the smoke/full/manual parameter topology with focused assertions.
  • git diff --check
  • Reviewed the complete diff using the repository code-review guidance; no blocking findings.

Note

This pull request and its description were created with GitHub Copilot assistance.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Preserve extra-platform parameter forwarding and restrict the full lane to intended scheduled or manual pipelines.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Moves full browser CoreCLR ReadyToRun library tests to scheduled and manual pipelines while retaining smoke coverage in default CI.

Changes:

  • Runs trimmed R2R smoke tests in the default runtime pipeline.
  • Adds full R2R testing to extra-platform and manual pipelines.
  • Documents /azp run runtime-wasm-libtests.
File Summary
eng/​pipelines/​runtime.yml Configures the default R2R smoke lane.
eng/​pipelines/​runtime-wasm-libtests.yml Enables full R2R tests for manual runs.
eng/​pipelines/​extra-platforms/​runtime-extra-platforms-wasm.yml Adds scheduled full R2R execution to extra-platform coverage.

Comment thread eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 21, 2026 17:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (1)

@lewing
lewing enabled auto-merge (squash) September 21, 2026 17:58
@lewing

lewing commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

/ba-g pipeline changes did the right thing

@lewing
lewing merged commit b4b6343 into main Sep 21, 2026
164 of 194 checks passed
@lewing
lewing deleted the lewing-wasm-r2r-smoke-lane branch September 21, 2026 19:29
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants