[release/11.0] Fix Android NativeAOT template for updated memory safety rules - #134365
Merged
Merged
Conversation
Fixes the Android NativeAOT build failure in the runtime-extra-platforms pipeline after System.Text.Json source-generation tests enabled `updated-memory-safety-rules`. The Android test template relied on type-level `unsafe` contexts, which have no effect under the updated rules. Move the contexts to the pointer operations and add explicit unsafe contracts to the native imports. The template remains compatible with the legacy rules. Validation: - `./build.sh tasks` - Compiled the template with legacy memory safety rules - Compiled the template with updated memory safety rules - Compiled the `SINGLE_FILE_TEST_RUNNER` path with updated memory safety rules > [!NOTE] > This PR description was generated with GitHub Copilot. Copilot-Session: e8bb4900-bf72-4876-b479-091185e5b89a
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
4 tasks
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
vitek-karas
approved these changes
Sep 21, 2026
davidnguyen-tech
approved these changes
Sep 21, 2026
agocke
enabled auto-merge (squash)
September 21, 2026 22:55
This was referenced Sep 22, 2026
Member
|
/azp run runtime-android |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Member
|
/ba-g test failure on osx which is unrelated to the android template changes here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #134212 to release/11.0
/cc @steveisok @agocke
Customer Impact
Test infra problem
Regression
Introduces with the latest round of safe/unsafe changes
Testing
Build break CI validates that the build break is gone
Risk
Low - test only change
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.