Reject truncated stored ZIP entry reads - #134499
Merged
Merged
Conversation
Co-authored-by: alinpahontu2912 <56953855+alinpahontu2912@users.noreply.github.com>
Co-authored-by: alinpahontu2912 <56953855+alinpahontu2912@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
alinpahontu2912
September 23, 2026 07:37
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/area-system-io-compression |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Exercise sync and async paths with their corresponding copy methods.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This pull request rejects truncated ZIP entry reads with InvalidDataException.
Changes:
- Detect early EOF before the declared uncompressed length.
- Update corrupted-entry regression tests.
| File | Summary |
|---|---|
src/libraries/System.IO.Compression/tests/ZipArchive/zip_InvalidParametersAndStrangeFiles.cs |
Updates truncation failure tests. |
src/libraries/System.IO.Compression/src/System/IO/Compression/ZipCustomStreams.cs |
Validates reads against the declared length. |
rzikm
approved these changes
Sep 23, 2026
alinpahontu2912
enabled auto-merge (squash)
September 23, 2026 08:38
Member
|
/ba-g failures are unrelated |
alinpahontu2912
approved these changes
Sep 24, 2026
cincuranet
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134496
Description
Fully drained ZIP entry reads now fail when EOF arrives before the declared uncompressed length, rather than completing without validating entry integrity.
InvalidDataExceptionfor early EOF inCrcValidatingReadStream.Note
This description was generated by GitHub Copilot.