Honor stack_limit in NativeAOT PromoteCarefully - #134506
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Member
Author
|
@jkotas, could you PTAL. LA64 failure is unrelated and seems intermittent, failed in other PRs as well (e.g. #134508, #134500, #134498]). cc @LuckyXu-HF, @shushanhf |
jkotas
reviewed
Sep 23, 2026
jkotas
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeAOT skipped any interior pointer within the thread's recorded
stack bounds. Under QEMU, musl over-reports the main thread's stack, so
heap byrefs were never reported and went stale when the GC moved
objects. Also require the address to be above stack_limit, as CoreCLR
does.
Fixes #130999