JIT: Make multiple try entries in an SCC an implLimitation in fgwasm - #134624
Merged
adamperlin merged 3 commits intoSep 25, 2026
Merged
adamperlin merged 3 commits into
adamperlin merged 3 commits into
Conversation
adamperlin
requested review from
AndyAyersMS
and
a lite review from Copilot
and removed request for
Copilot
September 24, 2026 22:32
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
AndyAyersMS
reviewed
Sep 24, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Use IMPL_LIMITATION(...) for diagnostics and correct the comment grammar.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates WebAssembly JIT SCC handling to classify multiple try-entry headers as an implementation limitation instead of triggering an NYI assertion.
Changes:
- Replaces the NYI path with implementation-limitation handling.
- Documents the unsupported control-flow case.
| File | Description |
|---|---|
src/coreclr/jit/fgwasm.cpp |
Changes handling of SCCs with multiple try entries. |
Co-authored-by: Andy Ayers <andya@microsoft.com>
AndyAyersMS
approved these changes
Sep 24, 2026
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This case is very rarely hit and would be complicated to fix so it was marked as NYI before. We do hit this in real code, though not in System.Private.CoreLib. Motivated by the following CI failure when compiling
Microsoft.Diagnostics.NETCore.Client