Conversation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jkotas
September 25, 2026 17:04
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The ARM-specific context layout and alignment safeguards need to be retained or proven unnecessary.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR removes obsolete ARM-specific debugging stubs and unifies thread-context macros across platforms.
Changes:
- Removes
SUPPORT_LOCAL_DEBUGGINGand ARM-only implementations. - Uses shared
GetThreadContext/SetThreadContextmacros for ARM.
| File | Summary |
|---|---|
src/coreclr/debug/di/stdafx.h |
Unifies context macros; a critical ARM layout and alignment concern remains. |
src/coreclr/debug/di/cordb.cpp |
Removes obsolete ARM implementations and configuration. |
Comment on lines
47
to
48
| #define DbiGetThreadContext(hThread, lpContext) ::GetThreadContext(hThread, (CONTEXT*)(lpContext)) | ||
| #define DbiSetThreadContext(hThread, lpContext) ::SetThreadContext(hThread, (CONTEXT*)(lpContext)) |
Member
There was a problem hiding this comment.
This path is only reachable with local debugging that cannot be cross compiled by design.
jkotas
reviewed
Sep 25, 2026
| #endif // FEATURE_DBGIPC_TRANSPORT_DI | ||
|
|
||
| #if defined(TARGET_UNIX) || defined(__ANDROID__) | ||
| // Local (in-process) debugging is not supported for UNIX and Android. |
Member
There was a problem hiding this comment.
Ancient left-over that is causing confusion
Context: dotnet/docs#56220 (comment)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUPPORT_LOCAL_DEBUGGINGindebug/di/cordb.cppwas used only by ARM's out-of-lineDbiGetThreadContext/DbiSetThreadContext. ARM32 is supported only on Unix, where the define was0, so both functions always asserted and returnedFALSE.debug/di/cordb.cppSUPPORT_LOCAL_DEBUGGINGdefine.DbiGetThreadContext/DbiSetThreadContextimplementations.debug/di/stdafx.hTARGET_ARMsplit.On ARM, callers now reach the PAL
GetThreadContext/SetThreadContext, the same as other Unix architectures, instead of an assert-and-fail stub. Most callers are inFEATURE_INTEROP_DEBUGGINGpaths, which are Windows-only.Note
This PR was generated by GitHub Copilot.