Skip to content

Use shared networking timeout in WebSocket tests - #134667

Merged
MihaZupan merged 1 commit into
dotnet:mainfrom
MihaZupan:mizupan-microsoft-websocket-close-test-reliability
Sep 25, 2026
Merged

MihaZupan merged 1 commit into
dotnet:mainfrom
MihaZupan:mizupan-microsoft-websocket-close-test-reliability

Conversation

@MihaZupan

Copy link
Copy Markdown
Member

The close-status test failed after 9.274 seconds because its cancellation deadline was only 5 seconds. Other WebSocket tests also use short, independent deadlines that can expire on slow CI machines.

Use the shared networking TestHelper.PassingTestTimeout (60 seconds) instead.

Resolves #134569

Note

This pull request was prepared with GitHub Copilot.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@MihaZupan MihaZupan added this to the 12.0.0 milestone Sep 25, 2026
@MihaZupan MihaZupan self-assigned this Sep 25, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan
MihaZupan enabled auto-merge (squash) September 25, 2026 20:53
@MihaZupan
MihaZupan merged commit a319567 into dotnet:main Sep 25, 2026
104 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Net.WebSockets.Tests.WebSocketCloseTests fail with TaskCanceledException

2 participants