[release/11.0] Support private scalar-only imports on iOS - #134702
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
On iOS / tvOS / MacCatalyst, importing an EC key with only `d` would fail because it was not implemented. Previously it was not implemented because CryptoKit was not available to the platform. But now it is, so lets implement it. This matters for HPKE - right now most integration tests for HPKE are failing because HPKE depends on being able to import only the private scalar. This fixes all HPKE tests on mobile Apple platforms.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
This was referenced Sep 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #134682 to release/11.0
/cc @vcsjones
Customer Impact
The HPKE functionality that was added to .NET 11 depends on EC-DH being able to import the private key without the public key. This was never implemented for iOS-like platforms, so this implements it.
Regression
Testing
Previously disabled tests are enabled and pass on iOS-like platforms.
Risk
Low. This code replaces a
PlatformNotSupportedExceptionpath with a working implementation. Other code paths are unchanged, so we are only changing a path that was guaranteed to fail to one that has a functional implementation.