[release/11.0] JIT: handle redefined enumerators in conditional escape analysis - #134709
Open
github-actions[bot] wants to merge 2 commits into
Open
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…4658) Fix conditional escape analysis when an enumerator local has multiple guarded definitions. The RPO walk now rejects an earlier cloning candidate when a later definition may reach its guarded uses, while preserving dominated sequential redefinitions. Validated with class and boxed-struct regressions, the disjoint zero-allocation case, Runtime_127075, and Runtime_131713. Resolves #134605 > [!NOTE] > This pull request description was generated with GitHub Copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ed9b45e3-0af5-4425-a189-1d0e0cbce294
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
@EgorBo PTAL |
EgorBo
approved these changes
Sep 26, 2026
Member
|
The new test is failing on NAOT - #134746. The fix for the test failure should be included in the backport. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 21c4f665-ddd2-4e24-82c9-476e45ed964e
Member
EgorBo
approved these changes
Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #134658 to release/11.0
/cc @AndyAyersMS
Customer Impact
#134605
Regression
Silent bad code gen. Bug in CEA since its inception (.NET 10)
Testing
Verified on repro case, no SPMI diffs.
Risk
Low, disqualifies an optimization when there is a potentially second reaching definition.
.