Skip to content

Guard against deserializing types with open generics#34163

Merged
layomia merged 7 commits into
dotnet:masterfrom
layomia:open_generics
Mar 31, 2020
Merged

Guard against deserializing types with open generics#34163
layomia merged 7 commits into
dotnet:masterfrom
layomia:open_generics

Conversation

@layomia

@layomia layomia commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

Fixes #30852.

@layomia layomia added this to the 5.0 milestone Mar 26, 2020
@layomia
layomia requested review from jozkee and steveharter March 26, 2020 22:14
@layomia
layomia requested a review from ahsonkhan as a code owner March 26, 2020 22:14
@layomia layomia self-assigned this Mar 26, 2020
@layomia layomia closed this Mar 26, 2020
@layomia layomia reopened this Mar 26, 2020
Comment thread src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs Outdated
Comment thread src/libraries/System.Text.Json/src/Resources/Strings.resx Outdated
Comment thread src/libraries/System.Text.Json/tests/Serialization/ExceptionTests.cs Outdated
Comment thread src/libraries/System.Text.Json/tests/Serialization/ExceptionTests.cs Outdated
Comment thread src/libraries/System.Text.Json/tests/Serialization/ExceptionTests.cs Outdated
Comment thread src/libraries/System.Text.Json/tests/Serialization/ExceptionTests.cs Outdated
@layomia
layomia requested review from jozkee and steveharter March 31, 2020 16:02

@steveharter steveharter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@layomia

layomia commented Mar 31, 2020

Copy link
Copy Markdown
Contributor Author

CI failure - #28553.

@layomia
layomia merged commit f973e96 into dotnet:master Mar 31, 2020
@layomia
layomia deleted the open_generics branch April 1, 2020 01:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonSerializer.Deserialize results in a null ref when attempting to deserialize open generic Nullable<>

5 participants