Add IncrementalHash.GetCurrentHash#37936
Merged
Merged
Conversation
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
vcsjones
reviewed
Jun 16, 2020
Member
|
Same link
|
Member
Author
|
Bah, should've linked to the 1.1.0 version 😁 |
stephentoub
reviewed
Jun 17, 2020
stephentoub
reviewed
Jun 17, 2020
stephentoub
reviewed
Jun 17, 2020
GrabYourPitchforks
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
int IncrementalHash::GetHashAndReset(Span<byte>)byte[] IncrementalHash::GetCurrentHash()int IncrementalHash::GetCurrentHash(Span<byte>)bool IncrementalHash::TryGetCurrentHash(Span<byte>, out int)While simplifying the internal logic (all three variants of GetHashAndReset collapse to the PAL
int GetHashAndReset(Span<byte>), and similarly for all three variants of GetCurrentHash).This change also drives the code coverage for the IncrementalHash class up to 100%.
Fixes #1968.