Skip to content

Removed Serialization tests for SQLClient types#42016

Merged
jkotas merged 5 commits into
dotnet:masterfrom
yujinnee:develop
Dec 3, 2020
Merged

Removed Serialization tests for SQLClient types#42016
jkotas merged 5 commits into
dotnet:masterfrom
yujinnee:develop

Conversation

@yujinnee

@yujinnee yujinnee commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

Fixes #38949

Removed OperationAbortedException because it was moved out of System.Data into SqlClient and so the testing belongs in the M.D.SqlClient repo. Other serialization tests for SQLClient types remain in this repo ,so I didn't removed them.

@ghost

ghost commented Sep 9, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @cheenamalhotra, @David-Engel
See info in area-owners.md if you want to be subscribed.

@@ -1,3 +1,4 @@

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please undo this whitespace change?

@jkotas

jkotas commented Sep 9, 2020

Copy link
Copy Markdown
Member

You should be also able to delete reference to System.Data.SqlClient from the project file.

@yujinnee

Copy link
Copy Markdown
Contributor Author

@jkotas I deleted white space and reference to System.Data.SqlClient!

@danmoseley

Copy link
Copy Markdown
Contributor

Why remove this and not tests in the same file for eg SqlException?

@yujinnee

Copy link
Copy Markdown
Contributor Author

@danmosemsft I referred to this comment. Can it be a proper answer to your question??

@jkotas

jkotas commented Sep 10, 2020

Copy link
Copy Markdown
Member

@jkotas

jkotas commented Sep 10, 2020

Copy link
Copy Markdown
Member

Also, the build errors suggest that there are more SqlClient-related types that should be deleted from this test.

@danmoseley

Copy link
Copy Markdown
Contributor

@danmosemsft I referred to this comment. Can it be a proper answer to your question??

I'm guessing @Wraith2 was suggesting that we remove tests for all types that no longer exist in this repo. There are many of these unfortunately -- you can see which files were deleted in this PR: https://github.com/dotnet/runtime/pull/2275/files

I don't know a systematic way to find tests for them, but it would be good if you're willing in this PR to remove tests from this file for types named SqlXXXX that you see deleted in the above PR. Thanks!

@dnfadmin

dnfadmin commented Sep 11, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@jkotas

jkotas commented Sep 11, 2020

Copy link
Copy Markdown
Member

@yujinnee

Copy link
Copy Markdown
Contributor Author

To delete that reference, should I also remove the serialization tests related to SQLClinet type in other cs file in System.Runtime.Serialization.Formatters/tests ?

@Wraith2

Wraith2 commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

Yes, anything that needs SqlClient can be removed. Anything which only needs System.Data.Common can be retained.

@jkotas
jkotas merged commit 4198f71 into dotnet:master Dec 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Serialization tests for SQLClient types now that they no longer live in the dotnet/runtime repo

6 participants