Skip to content

Move serializable types for xml serialization generator tests to separate assembly#44164

Merged
safern merged 2 commits into
dotnet:masterfrom
safern:SerializerGenTests
Nov 3, 2020
Merged

Move serializable types for xml serialization generator tests to separate assembly#44164
safern merged 2 commits into
dotnet:masterfrom
safern:SerializerGenTests

Conversation

@safern

@safern safern commented Nov 2, 2020

Copy link
Copy Markdown
Member

@safern
safern requested review from ViktorHofer and ericstj November 2, 2020 20:54
@ghost

ghost commented Nov 2, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@safern safern removed the area-Meta label Nov 2, 2020
ericstj
ericstj approved these changes Nov 2, 2020
View reviewed changes

@ericstj ericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. It might be helpful to note somewhere the "why" behind this separation.

@safern

safern commented Nov 2, 2020

Copy link
Copy Markdown
Member Author

Looks ok to me. It might be helpful to note somewhere the "why" behind this separation.

I'll add a comment to the SerializableAssembly csproj.

@GrabYourPitchforks

GrabYourPitchforks commented Nov 2, 2020

Copy link
Copy Markdown
Member

🥳

@safern

safern commented Nov 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Failures are unrelated and known.

@safern
safern merged commit 6951dd7 into dotnet:master Nov 3, 2020
@safern
safern deleted the SerializerGenTests branch November 3, 2020 02:03
ViktorHofer
ViktorHofer reviewed Nov 3, 2020
View reviewed changes

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ViktorHofer

ViktorHofer commented Nov 3, 2020

Copy link
Copy Markdown
Member

Failures are unrelated and known.

Are you sure about the test failure?

System.IO.Compression.GzipStreamUnitTests.Write_DataReadFromDesiredOffset(mode: AsyncAPM) failed and I couldn't find a tracking issue for it and created one: #44189

@stephentoub

stephentoub commented Nov 3, 2020

Copy link
Copy Markdown
Member

I couldn't find a tracking issue for it

#44173

@ViktorHofer

ViktorHofer commented Nov 3, 2020

Copy link
Copy Markdown
Member

Cool. Why does Github search not list that issue? https://github.com/dotnet/runtime/search?q=Write_DataReadFromDesiredOffset&type=issues

@stephentoub

stephentoub commented Nov 3, 2020

Copy link
Copy Markdown
Member

GitHub search isn't great. If you search for the full name, you'll find it:
https://github.com/dotnet/runtime/search?q=System.IO.Compression.GzipStreamUnitTests.Write_DataReadFromDesiredOffset&type=issues

@ViktorHofer

ViktorHofer commented Nov 3, 2020

Copy link
Copy Markdown
Member

Thanks

This was referenced Nov 3, 2020
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments
@ericstj ericstj ericstj approved these changes
+1 more reviewer
@Anipik Anipik Anipik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invoking SGen creates a dependency on the repo local's shared framework

7 participants

@safern @GrabYourPitchforks @ViktorHofer @stephentoub @ericstj @Anipik @Dotnet-GitSync-Bot