Skip to content

Expand PriorityQueue test coverage - #48420

Merged
eiriktsarpalis merged 7 commits into
dotnet:masterfrom
eiriktsarpalis:add-priorityqueue-tests
Feb 19, 2021
Merged

Expand PriorityQueue test coverage#48420
eiriktsarpalis merged 7 commits into
dotnet:masterfrom
eiriktsarpalis:add-priorityqueue-tests

Conversation

@eiriktsarpalis

Copy link
Copy Markdown
Member

Extends PriorityQueue test coverage in the following ways:

  • Abstracts the IComparer<TPriority> parameter in the PriorityQueue generic test class so that all code paths added in PriorityQueue: Apply Comparer<T>.Default optimization #48346 are exercised.
  • Adds a few missing unit tests.
  • Minor refactorings and rearrangements of existing tests.
  • Adds property tests for PriorityQueue, a form of structured fuzzing already used in the Cbor project.

@ghost

ghost commented Feb 17, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Extends PriorityQueue test coverage in the following ways:

  • Abstracts the IComparer<TPriority> parameter in the PriorityQueue generic test class so that all code paths added in PriorityQueue: Apply Comparer<T>.Default optimization #48346 are exercised.
  • Adds a few missing unit tests.
  • Minor refactorings and rearrangements of existing tests.
  • Adds property tests for PriorityQueue, a form of structured fuzzing already used in the Cbor project.
Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Collections

Milestone: -

Comment thread src/libraries/System.Collections/tests/System.Collections.Tests.csproj Outdated

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@eiriktsarpalis
eiriktsarpalis merged commit adc73fb into dotnet:master Feb 19, 2021
@eiriktsarpalis
eiriktsarpalis deleted the add-priorityqueue-tests branch February 19, 2021 10:02
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants