JIT: Fix loop unscaling computations#50807
Merged
Merged
Conversation
Changes made in dotnet#50633 were simply wrong, and lead to division by infinite values. Fixes dotnet#50743.
Member
Author
|
@BruceForstall PTAL Will post diffs shortly. |
Member
Author
|
There is another issue here which I'll address separately (#50808). The guarding condition |
BruceForstall
approved these changes
Apr 6, 2021
Member
Author
|
31 diffs across SPMI... spot checked a few, and all were from leaving block weights too high after removing a loop. |
Contributor
|
@AndyAyersMS I presume you're still waiting on this until you can get our CI to behave? The assert this fixes is pervasive in CI jobs, so hopefully we can get this in sooner rather than later. |
Member
Author
Yes. Seems like things are still not where they should be. |
Member
Author
|
Going to bounce this. |
Member
Author
|
Look at that, all green... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in #50633 were simply wrong, and lead to division by
infinite values.
Fixes #50743.