Skip to content

Remove the unused AEADBCryptHandles.cs#53736

Merged
bartonjs merged 1 commit into
dotnet:mainfrom
teo-tsirpanis:aead-bcrypt-handles
Jun 4, 2021
Merged

Remove the unused AEADBCryptHandles.cs#53736
bartonjs merged 1 commit into
dotnet:mainfrom
teo-tsirpanis:aead-bcrypt-handles

Conversation

@teo-tsirpanis

@teo-tsirpanis teo-tsirpanis commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Introduced in #52030, AEADBCryptHandles.cs is almost identical to another new file of that PR, BCryptAEADHandleCache.cs. Contrary to the latter however, the former is not used at all (searching AEADBCryptHandles.cs gave only one results on the file itself; presumably it was left by accident and slipped code review). This PR removes it.

@ghost ghost added the area-System.Security label Jun 4, 2021
@ghost

ghost commented Jun 4, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduced in #52030, AEADBCryptHandles.cs is almost identical to another new file of that PR, BCryptAEADHandleCache.cs. Contrary to the latter however, the former is not used at all (searching AEADBCryptHandles.cs gave only one results on the file itself; persumably it was left by accident and slipped code review). This PR removes it.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Security

Milestone: -

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. Thanks.

@bartonjs bartonjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprise had me waiting until CI confirmed it first, but, yeah. "So long as CI agrees..."

@bartonjs
bartonjs merged commit 303e42c into dotnet:main Jun 4, 2021
@bartonjs

bartonjs commented Jun 4, 2021

Copy link
Copy Markdown
Member

Weird. Thanks for helping keep us tidy 😄.

@teo-tsirpanis
teo-tsirpanis deleted the aead-bcrypt-handles branch June 4, 2021 20:47
@ghost ghost locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants