Remove unused private parameters in SPC#63015
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
3c0f748 to
a0c6c87
Compare
and remove related dead code
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue Detailsand remove related dead code
|
|
Many instances of this stylecop warning were cleaned up in dotnet/coreclr#26104, but the enforcement was not enabled enforcement as part of that PR. cc @stephentoub |
| internal static bool CanSetMaxIOCompletionThreads(int ioCompletionThreads) => true; | ||
| #pragma warning restore IDE0060 | ||
|
|
||
| [Conditional("unnecessary")] |
There was a problem hiding this comment.
Some of the similar cases are partial methods. Is there are reason why these are Conditional("unnecessary") and not partial methods?
There was a problem hiding this comment.
They are not private hence we cannot use a partial method without an implementation.
Because there was a lot left to do across the repo :) |
|
@marek-safar, are you planning to fix all occurrences of this across the repo and enable the rule? Otherwise, I'm not a big fan of adding a lot of suppressions for a rule we explicitly disable. |
I'd like in 2022 ;-) |
and remove related dead code