[wasm][debugger] Sort properties by protection level in structures.#63339
Closed
ilonatommy wants to merge 7 commits into
Closed
[wasm][debugger] Sort properties by protection level in structures.#63339ilonatommy wants to merge 7 commits into
ilonatommy wants to merge 7 commits into
Conversation
|
Tagging subscribers to this area: @thaystg Issue DetailsContinuation of #62627
|
ilonatommy
marked this pull request as ready for review
January 5, 2022 09:34
ilonatommy
requested review from
lambdageek and
thaystg
and removed request for
marek-safar
January 5, 2022 09:34
lambdageek
reviewed
Jan 5, 2022
thaystg
reviewed
Jan 10, 2022
radical
requested changes
Jan 11, 2022
radical
reviewed
Jan 11, 2022
radical
reviewed
Jan 11, 2022
radical
reviewed
Jan 11, 2022
ilonatommy
force-pushed
the
structure-properties-internal-private
branch
from
March 29, 2022 07:51
90d15b5 to
88d5d7f
Compare
ilonatommy
force-pushed
the
structure-properties-internal-private
branch
from
March 31, 2022 07:12
ff205b9 to
3ff5fcb
Compare
…o Extentions is not needed in this situation.
ilonatommy
force-pushed
the
structure-properties-internal-private
branch
from
April 4, 2022 08:31
3b74495 to
693c4f6
Compare
Member
Author
|
/azp run runtime-staging |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Staging of EvaluateOnCallFrameTests has a timeout but passes locally. |
lewing
reviewed
Apr 5, 2022
lewing
left a comment
Member
There was a problem hiding this comment.
The changes look ok but it only tests the value of the string now, do we have any tests for more complicated types?
|
This pull request has been automatically marked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63082 and is a continuation of #62627.