Add RL non-generic fixed window, sliding window implementations by shreyaverma165 · Pull Request #68087 · dotnet/runtime

shreyaverma165 · 2022-04-15T20:26:26Z

** Updating this PR with comments and test cases.

ghost · 2022-04-15T20:26:32Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2022-04-15T20:26:35Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: dotnet/aspnetcore#37381

** Updating this PR with comments and test cases.

Author:	shreyaverma165
Assignees:	-
Labels:	`area-System.Threading`
Milestone:	7.0.0

dnfadmin · 2022-04-15T20:26:41Z

All CLA requirements met.

BrennanConroy · 2022-04-19T03:56:27Z

I think the ref file needs to be updated. dotnet msbuild /t:GenerateReferenceAssemblySource

…et#68087)

…eate (#68695) * Add RL non-generic fixed window, sliding window implementations (#68087) * Add initial impl of PartitionedRateLimiter.Create (#67677) Co-authored-by: Shreya Verma <shve9863@colorado.edu>

shreyaverma165 added the area-System.Threading label Apr 15, 2022

shreyaverma165 added this to the 7.0.0 milestone Apr 15, 2022

shreyaverma165 requested review from BrennanConroy and halter73 April 15, 2022 20:26

ghost assigned shreyaverma165 Apr 15, 2022

ghost added the new-api-needs-documentation label Apr 15, 2022

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch 3 times, most recently from f20f4a9 to 8ad696c Compare April 15, 2022 20:43

BrennanConroy reviewed Apr 15, 2022

View reviewed changes

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch 3 times, most recently from 5add2b3 to 601f6fd Compare April 19, 2022 00:11

shreyaverma165 marked this pull request as ready for review April 19, 2022 00:12

shreyaverma165 requested a review from BrennanConroy April 19, 2022 00:13

BrennanConroy reviewed Apr 19, 2022

View reviewed changes

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 953b529 to 6c3f70a Compare April 19, 2022 03:02

shreyaverma165 requested a review from BrennanConroy April 19, 2022 04:34

BrennanConroy reviewed Apr 19, 2022

View reviewed changes

shreyaverma165 marked this pull request as draft April 19, 2022 17:08

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch 4 times, most recently from 4cb332f to e825bd1 Compare April 25, 2022 08:47

shreyaverma165 marked this pull request as ready for review April 25, 2022 08:48

shreyaverma165 requested a review from BrennanConroy April 25, 2022 08:48

shreyaverma165 marked this pull request as ready for review April 25, 2022 23:54

shreyaverma165 requested a review from BrennanConroy April 25, 2022 23:54

BrennanConroy reviewed Apr 26, 2022

View reviewed changes

Comment thread .../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 218b8dc to d368ecd Compare April 26, 2022 18:58

shreyaverma165 requested a review from BrennanConroy April 26, 2022 19:53

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 049e500 to a1f8d68 Compare April 26, 2022 21:54

BrennanConroy reviewed Apr 27, 2022

View reviewed changes

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from a1f8d68 to 12de257 Compare April 27, 2022 19:32

shreyaverma165 requested a review from BrennanConroy April 27, 2022 20:08

BrennanConroy approved these changes Apr 27, 2022

View reviewed changes

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 12de257 to 743ca69 Compare April 27, 2022 22:25

shreyaverma165 added 12 commits April 28, 2022 12:23

Add RL non-generic fixed window, sliding window implementations

5c8840c

Add updates to the sliding window GetAvailablePermits

ee146d5

Revert changes made to BclInterfaces/ref file

62dc02c

Update ref/System.Threading.RateLimiting

43b5e03

import Tasks namespace

1535b57

Update tests anf fix up test failures caused by window segments

7c89e54

Add fixes to sliding window rate limiting tests

4199046

Update sliding window tests to use a window size greater than 1

5c00494

Update how oldSegmentRequestCount is calculated

64b9c2e

Add test to verify multiple acquires

60302a3

Adding comments

7ac2e15

Add the failed queued requests back to available permits

5a10be2

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 743ca69 to 5a10be2 Compare April 28, 2022 19:24

BrennanConroy merged commit 1d7c119 into dotnet:main Apr 28, 2022

BrennanConroy mentioned this pull request Apr 28, 2022

Finish implementations for non-generic rate limiters (Fixed windows, Sliding windows, Token bucket, Concurrency limiter) dotnet/aspnetcore#37381

Closed

4 tasks

BrennanConroy pushed a commit to BrennanConroy/runtime that referenced this pull request Apr 29, 2022

Add RL non-generic fixed window, sliding window implementations (dotn…

d649022

…et#68087)

BrennanConroy mentioned this pull request Apr 29, 2022

Add Fixed and Sliding Window RateLimiters + PartitionedRateLimiter.Create #68695

Merged

ghost locked as resolved and limited conversation to collaborators Jul 10, 2022

Uh oh!

Conversation

shreyaverma165 commented Apr 15, 2022

Uh oh!

ghost commented Apr 15, 2022

Uh oh!

ghost commented Apr 15, 2022

Uh oh!

dnfadmin commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrennanConroy commented Apr 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dnfadmin commented Apr 15, 2022 •

edited

Loading