Skip to content

Add requested version to hostfxr_resolve_sdk2#68355

Merged
elinor-fung merged 2 commits into
dotnet:mainfrom
elinor-fung:sdkRequestedVersion
Apr 25, 2022
Merged

Add requested version to hostfxr_resolve_sdk2#68355
elinor-fung merged 2 commits into
dotnet:mainfrom
elinor-fung:sdkRequestedVersion

Conversation

@elinor-fung

@elinor-fung elinor-fung commented Apr 21, 2022

Copy link
Copy Markdown
Member

Add hostfxr_resolve_sdk2_result_key_t::requested_version for indicating the SDK version requested (if any). The callback will be invoked with that key only if there was a version specified.

@ghost

ghost commented Apr 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Add hostfxr_resolve_sdk2_result_key_t::requested_version for indicating the SDK version requested (if any).

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

@elinor-fung elinor-fung reopened this Apr 22, 2022

@vitek-karas vitek-karas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread src/native/corehost/fxr/hostfxr.cpp
Comment thread src/native/corehost/fxr/sdk_resolver.cpp Outdated

@vitek-karas vitek-karas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@elinor-fung

Copy link
Copy Markdown
Member Author

Failure is #67761

@elinor-fung
elinor-fung merged commit 3f4ac7f into dotnet:main Apr 25, 2022
@elinor-fung
elinor-fung deleted the sdkRequestedVersion branch April 25, 2022 17:27
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants