Fold System.Private.Reflection.Core into CoreLib

[jkotas]

No description provided.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	jkotas
Assignees:	jkotas
Labels:	area-System.Reflection
Milestone:	-

[MichalStrehovsky]

Thanks!

[MichalStrehovsky]

The warning that is failing the build is dotnet/linker#2790.

It complains that we're creating a delegate to a method with annotations. Trimming cannot enforce the delegate will be always called from places that are analyzable.

A good fix might be to just remove the annotations on the method and add a warning suppression instead (it's going to warn that we call GetUninitializedObject). It's always safe to call GetUninitializedObject on an underlying type of a nullable. We also have a test for that being added in #70201 (TestVTableOfNullableUnderlyingTypes).

[MichalStrehovsky]

[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2072:UnrecognizedReflectionPattern",
            Justification = "Constructed MethodTable of a Nullable forces a constructed MethodTable of the element type")]

Is the suppression we have on GetUninitializedObject that will probably suppress the right thing here.

[jkotas]

Failure is #70626