Fix ldelem[a]/stelem/cpobj/ldobj/stobj <pointer type> import#71679
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFixes #71636.
|
jkotas
reviewed
Jul 6, 2022
jkotas
reviewed
Jul 6, 2022
SingleAccretion
force-pushed
the
Ldlem-Pointers
branch
from
July 6, 2022 17:49
9bec633 to
d63a0a3
Compare
ldelem[a] <pointer type> importldelem[a]/stelem/cpobj/ldobj/stobj <pointer type> import
SingleAccretion
marked this pull request as ready for review
July 7, 2022 16:21
Contributor
Author
|
@dotnet/jit-contrib |
There was no actual problem with it because the "stelem.ref" logic takes the type to store from the value to store, but let's make the code obviously correct.
They were relaxed in dotnet#50749.
SingleAccretion
force-pushed
the
Ldlem-Pointers
branch
from
July 7, 2022 20:09
5bb1cc3 to
6062b23
Compare
jkotas
approved these changes
Jul 15, 2022
EgorBo
approved these changes
Jul 28, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To treat pointers as integers and not
objects.Fixes #71636.