Skip to content

Update design and expose new attributes for the CustomTypeMarshaller support#71682

Merged
jkoritzinsky merged 9 commits into
dotnet:mainfrom
jkoritzinsky:update-api-surface
Jul 6, 2022
Merged

Update design and expose new attributes for the CustomTypeMarshaller support#71682
jkoritzinsky merged 9 commits into
dotnet:mainfrom
jkoritzinsky:update-api-surface

Conversation

@jkoritzinsky

@jkoritzinsky jkoritzinsky commented Jul 5, 2022

Copy link
Copy Markdown
Member

Update the design of the V2 marshallers based on API review feedback.

Expose the CustomTypeMarshallerAttribute class and the MarshalMode enum so we can use them to update ASP.NET Core's custom marshallers and delete the V1 model sooner.

Also block the analyzer from warning on the V2 design for now until we actually get it updated.

Contributes to #70859

@jkoritzinsky jkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jul 5, 2022
@ghost

ghost commented Jul 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Update the design of the V2 marshallers based on API review feedback.

Expose the CustomTypeMarshallerAttribute class and the MarshalMode enum so we can use them to update ASP.NET Core's custom marshallers and delete the V1 model sooner.

Contributes to #70859

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: -

@ghost

ghost commented Jul 5, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Comment thread docs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md Outdated
Comment thread docs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md Outdated
@jkoritzinsky

Copy link
Copy Markdown
Member Author

Failures are a network blip and #71684

@jkoritzinsky
jkoritzinsky merged commit c99b5b0 into dotnet:main Jul 6, 2022
@jkoritzinsky
jkoritzinsky deleted the update-api-surface branch July 6, 2022 16:35
@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants