Correctly find the node to fix in regex generator codefix#72079
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsFixes #72047
|
| // Find the node that corresponding to the diagnostic which we will then fix. | ||
| SyntaxNode? root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false); | ||
| if (root is null) | ||
| { | ||
| return document; | ||
| } | ||
|
|
||
| SyntaxNode nodeToFix = root.FindNode(diagnostic.Location.SourceSpan, getInnermostNodeForTie: false); |
There was a problem hiding this comment.
No need to re-calculate these. They were already calculated and can be passed along. I think the result cannot have changed in-between the calls, basically because Document is immutable and we're using the same document to re-calculate.
|
Tagging @joperezr @stephentoub for review. |
|
Thanks @Youssef1313. You're awesome! |
|
Looks like my latest PR caused a merge conflict on the tests. I took the liberty of fixing the merge conflict and pushing to your PR, I hope that is ok. Will merge this as soon as CI is green. |
|
@joperezr CI failures are unrelated. |
Fixes #72047