Skip to content

Fix for m_alignpad == 0 assertion failure#72475

Merged
mrsharm merged 3 commits into
dotnet:mainfrom
mrsharm:assertionfailurefix
Jul 20, 2022
Merged

Fix for m_alignpad == 0 assertion failure#72475
mrsharm merged 3 commits into
dotnet:mainfrom
mrsharm:assertionfailurefix

Conversation

@mrsharm

@mrsharm mrsharm commented Jul 19, 2022

Copy link
Copy Markdown
Member

Fixes #70231 by:

  1. Removing the demotion check
  2. Adding a null check on the GCSafeMethodTable

Also, we are now logging the m_alignpad value instead of the object address in the IllegalAlignPad function.

@ghost ghost added the area-GC-coreclr label Jul 19, 2022
@ghost ghost assigned mrsharm Jul 19, 2022
@ghost

ghost commented Jul 19, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #70231 by:

  1. Removing the demotion check
  2. Adding a null check on the GCSafeMethodTable

Also, we are now logging the m_alignpad value instead of the object address in the IllegalAlignPad function.

Author: mrsharm
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@Maoni0

Maoni0 commented Jul 19, 2022

Copy link
Copy Markdown
Member

does the LogSpewAlways actually log something in the stress log the way these tests are run? when I looked at the dumps this message was not there.

Comment thread src/coreclr/vm/syncblk.cpp Outdated
@mrsharm
mrsharm marked this pull request as ready for review July 20, 2022 14:48
@mrsharm
mrsharm requested review from PeterSolMS, cshung and mangod9 July 20, 2022 14:48
@mrsharm
mrsharm merged commit bc05381 into dotnet:main Jul 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assert failure: m_alignpad == 0 in libraries tests

3 participants