Skip to content

HTTP/3 Made alt-used show only on alt-svc redirect#72669

Merged
CarnaViire merged 8 commits into
dotnet:mainfrom
iuliaco:56876_alt-svc_not_used_fix
Jul 28, 2022
Merged

HTTP/3 Made alt-used show only on alt-svc redirect#72669
CarnaViire merged 8 commits into
dotnet:mainfrom
iuliaco:56876_alt-svc_not_used_fix

Conversation

@iuliaco

@iuliaco iuliaco commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

Fixes #56876
I only did a test for checking not alt-used included, tests which include checking alt-used header are already implemented here.

@ghost ghost added area-System.Net.Http community-contribution Indicates that the PR has been added by a community member labels Jul 22, 2022
@ghost

ghost commented Jul 22, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #56876
I only did a test for checking not alt-used included, tests which include checking alt-used header are already implemented here.

Author: iuliaco
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@ManickaP
ManickaP requested a review from a team July 22, 2022 11:08
@ManickaP ManickaP removed the community-contribution Indicates that the PR has been added by a community member label Jul 22, 2022

@CarnaViire CarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits, thanks!

iuliaco and others added 2 commits July 27, 2022 10:39
…HandlerTest.Http3.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
…HandlerTest.Http3.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
@CarnaViire

Copy link
Copy Markdown
Member

@iuliaco could you please update your branch to the current main (because #72854 is merged now), so we could rerun the tests in CI without Http tests being timed out

@iuliaco

iuliaco commented Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

Done

@CarnaViire
CarnaViire merged commit 812ad81 into dotnet:main Jul 28, 2022
@karelz karelz added this to the 7.0.0 milestone Aug 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Http/3 adds alt-used header even when alt-svc isn't is used

4 participants