Fix race when receiving HEADERS and RST_STREAM in rapid succession.#72932
Merged
rzikm merged 2 commits intoJul 28, 2022
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #68373. This PR makes requests made with
|
rzikm
force-pushed
the
68373-HTTP2-Possible-race-when-receiving-HEADERS-and-RST_STREAM-together
branch
from
July 27, 2022 10:53
258a0eb to
4f0e1c1
Compare
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MihaZupan
approved these changes
Jul 27, 2022
| await _connectionStream.WriteAsync(writeBuffer, 0, writeBuffer.Length, cancellationToken).ConfigureAwait(false); | ||
| } | ||
|
|
||
| public async Task WriteFramesAsync(Frame[] frames, CancellationToken cancellationToken = default) |
Member
There was a problem hiding this comment.
This is just to make the test more likely to fail without the fix, right?
Member
Author
|
Test failure is #72586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68373.
This PR makes requests made with
HttpCompletionOption.ResponseHeadersReadfinish successfully even if we receive RST_STREAM frame after successfully receiving response headers.