Make diagnostic checks more reliable with more exact result matching.#73178
Merged
Conversation
Fixes dotnet#73127 Generate DiagnosticResult values with the actual diagnostic message instead of just the message arguments to help direct the test harness to directly match the expected diagnostics with the actual diagnostics.
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #73127 Generate DiagnosticResult values with the actual diagnostic message instead of just the message arguments to help direct the test harness to directly match the expected diagnostics with the actual diagnostics.
|
AaronRobinsonMSFT
approved these changes
Aug 1, 2022
Member
|
Do we need to do the same thing for the stateful collection, stateless value, and stateless collection shape validation tests? |
Member
Author
|
I think we might need to do the same for stateful collection, but I'm not sure with the stateless shapes. I'll do a quick pass and see if there's any other ones I need to handle. |
Use helper in more tests where this could technically be an issue.
elinor-fung
approved these changes
Aug 1, 2022
Member
Author
|
Failure is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73127
Generate DiagnosticResult values with the actual diagnostic message instead of just the message arguments to help direct the test harness to directly match the expected diagnostics with the actual diagnostics.