[main] Update dependencies from dotnet/linker by dotnet-maestro[bot] · Pull Request #73410 · dotnet/runtime

dotnet-maestro · 2022-08-04T22:56:06Z

This pull request updates the following dependencies

From https://github.com/dotnet/linker

Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
Build: 20220811.2
Date Produced: August 12, 2022 1:09:55 AM UTC
Commit: 81ffbb5af38a45ff60648999df8f35a79061ae43
Branch: refs/heads/main

Updates:
- Microsoft.NET.ILLink.Tasks: from 7.0.100-1.22377.1 to 7.0.100-1.22411.2

…804.4 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.4

…804.5 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.5

lewing · 2022-08-05T17:06:55Z

cc @vitek-karas

…805.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22405.1

vitek-karas · 2022-08-08T12:23:15Z

@sbomer is looking into this

…808.3 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22408.3

vitek-karas · 2022-08-09T13:45:37Z

Once the "linker can't run" problem is fixed, there will be additional failures caused by fixes in the linker (runtime has wrong/missing suppression in some places). @jkurdek is working fixing these.

…d6-48d3-a9c9-4fe95633fbd2

…809.9 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22409.9

sbomer · 2022-08-10T00:06:46Z

@jkurdek the runtime version issue is resolved now, and the new warnings are showing up.

radical · 2022-08-10T00:55:18Z

Latest main has an issue with linker - dotnet/linker#2963

radical · 2022-08-11T01:59:19Z

Wasm samples failing with::

/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser/Wasm.Browser.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/browser/Wasm.Browser.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/console-node/Wasm.Console.Node.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/console-node/Wasm.Console.Node.Sample.csproj]

/_/src/mono/sample/wasm/browser-bench/Json.cs(43,13): Trim analysis error IL2121: Sample.JsonTask.Initialize(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(113,47): Trim analysis error IL2121: Sample.JsonTask.LargeDeserialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(101,47): Trim analysis error IL2121: Sample.JsonTask.LargeSerialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(89,47): Trim analysis error IL2121: Sample.JsonTask.SmallDeserialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(78,47): Trim analysis error IL2121: Sample.JsonTask.SmallSerialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Program.cs(45,13): Trim analysis error IL2121: Sample.Test.SetTasks(String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2057'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Program.cs(45,13): Trim analysis error IL2121: Sample.Test.SetTasks(String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2072'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(67,47): Trim analysis error IL2121: Sample.JsonTask.TextDeserialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/_/src/mono/sample/wasm/browser-bench/Json.cs(56,47): Trim analysis error IL2121: Sample.JsonTask.TextSerialize.RunStep(): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]

/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.ComponentModel.TypeConverter.dll : error IL2104: Assembly 'System.ComponentModel.TypeConverter' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Runtime.InteropServices.JavaScript.dll : error IL2104: Assembly 'System.Runtime.InteropServices.JavaScript' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Text.Json.dll : error IL2104: Assembly 'System.Text.Json' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/console-v8/Wasm.Console.V8.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/console-v8/Wasm.Console.V8.Sample.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/mono/sample/wasm/browser-profile/Wasm.BrowserProfile.Sample.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/mono/sample/wasm/browser-profile/Wasm.BrowserProfile.Sample.csproj]

Library tests on wasm built with trimming failing:

/_/src/libraries/System.Runtime/tests/System/Type/TypeTests.cs(158,13): Trim analysis error IL2121: System.Tests.TypeTests.FindMembers_Invoke_ReturnsExpected(MemberTypes, BindingFlags, MemberFilter, Object, Int32): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2118'. Consider removing the unused warning suppression. [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.ComponentModel.TypeConverter.dll : error IL2104: Assembly 'System.ComponentModel.TypeConverter' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Linq.Expressions.dll : error IL2104: Assembly 'System.Linq.Expressions' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Linq.Queryable.dll : error IL2104: Assembly 'System.Linq.Queryable' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/lib/net7.0/System.Runtime.InteropServices.JavaScript.dll : error IL2104: Assembly 'System.Runtime.InteropServices.JavaScript' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/artifacts/bin/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/System.Private.CoreLib.dll : error IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]
/__w/1/s/.dotnet/sdk/7.0.100-preview.5.22307.18/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(110,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj]

…d6-48d3-a9c9-4fe95633fbd2

radical · 2022-08-11T02:03:02Z

/azp run runtime-wasm-perf

azure-pipelines · 2022-08-11T02:03:12Z

Azure Pipelines successfully started running 1 pipeline(s).

sbomer · 2022-08-11T16:46:06Z

@radical I tried to disable IL2121 in the wasm samples as well. Would you be able to do the same anywhere else that it needs to be disabled for wasm? I believe this can be undone with a preview6 SDK (which should import linker targets from the latest package, where we disable the warning).

vitek-karas · 2022-08-12T12:28:44Z

/azp run runtime-wasm-perf

azure-pipelines · 2022-08-12T12:28:57Z

Azure Pipelines successfully started running 1 pipeline(s).

…811.2 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22411.2

vitek-karas · 2022-08-12T14:23:08Z

/azp run runtime-wasm-perf

azure-pipelines · 2022-08-12T14:23:22Z

Azure Pipelines successfully started running 1 pipeline(s).

vitek-karas · 2022-08-12T17:21:33Z

The only failure is linux_musl arm64 libraries test run timing out which is happening other PRs as well.

Update dependencies from https://github.com/dotnet/linker build 20220…

5cfe016

…804.4 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.4

ghost added the area-codeflow for labeling automated codeflow label Aug 4, 2022

Update dependencies from https://github.com/dotnet/linker build 20220…

62e46fb

…804.5 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.5

Update dependencies from https://github.com/dotnet/linker build 20220…

c1500d0

…805.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22405.1

Update dependencies from https://github.com/dotnet/linker build 20220…

ff7c308

…808.3 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22408.3

radical and others added 2 commits August 9, 2022 20:49

Merge remote-tracking branch 'origin/main' into darc-main-00cadd7b-bd…

628d97c

…d6-48d3-a9c9-4fe95633fbd2

Update dependencies from https://github.com/dotnet/linker build 20220…

2617983

…809.9 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22409.9

This was referenced Aug 10, 2022

Revert "Generic attributes handling in CustomAttributeDecoder" #73671

Merged

[wasm] ILLinker crash System.NotImplementedException: Var in System.Reflection.Metadata tests dotnet/linker#2963

Closed

jkurdek and others added 3 commits August 10, 2022 06:42

Added and modified suppressions

40fa30a

Disable IL2121 everywhere for now

e65381b

Disable IL2121 in trimming tests

aefce83

Merge remote-tracking branch 'origin/main' into darc-main-00cadd7b-bd…

0da54f3

…d6-48d3-a9c9-4fe95633fbd2

Disable IL2121 in wam samples

d672e5e

dotnet-maestro Bot requested review from lewing and pavelsavara as code owners August 11, 2022 16:43

Disable IL2121 in libraries tests

ba81edf

Update dependencies from https://github.com/dotnet/linker build 20220…

144c25e

…811.2 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22411.2

vitek-karas approved these changes Aug 12, 2022

View reviewed changes

vitek-karas merged commit 31d5d23 into main Aug 12, 2022

dotnet-maestro Bot deleted the darc-main-00cadd7b-bdd6-48d3-a9c9-4fe95633fbd2 branch August 12, 2022 17:25

ghost locked as resolved and limited conversation to collaborators Sep 11, 2022

Uh oh!

Conversation

dotnet-maestro Bot commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/linker

Uh oh!

lewing commented Aug 5, 2022

Uh oh!

vitek-karas commented Aug 8, 2022

Uh oh!

vitek-karas commented Aug 9, 2022

Uh oh!

sbomer commented Aug 10, 2022

Uh oh!

radical commented Aug 10, 2022

Uh oh!

radical commented Aug 11, 2022

Uh oh!

radical commented Aug 11, 2022

Uh oh!

azure-pipelines Bot commented Aug 11, 2022

Uh oh!

sbomer commented Aug 11, 2022

Uh oh!

vitek-karas commented Aug 12, 2022

Uh oh!

azure-pipelines Bot commented Aug 12, 2022

Uh oh!

vitek-karas commented Aug 12, 2022

Uh oh!

azure-pipelines Bot commented Aug 12, 2022

Uh oh!

vitek-karas commented Aug 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dotnet-maestro Bot commented Aug 4, 2022 •

edited

Loading