Split and simplify fgMorphOneAsgBlockOp#76793
Merged
jakobbotsch merged 11 commits intoNov 9, 2022
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThe main goal of this change is to extract the parts of To that end:
|
SingleAccretion
force-pushed
the
Slimming-Down-OneAsg-Morphing-Upstream
branch
from
October 9, 2022 12:51
aa5115b to
4284dc3
Compare
SingleAccretion
marked this pull request as ready for review
October 9, 2022 15:51
Contributor
Author
|
@dotnet/jit-contrib The CI is down, but this is otherwise ready for review. |
Closed
This was referenced Oct 10, 2022
Closed
No point in creating block nodes for simple types.
Avoids a couple regressions.
A zero-diff checkpoint.
A zero-diff checkpoint.
3 small regressions across all of SPMI due to less aggressive
CSEing ("LCL_FLD" is costed cheaper than "IND(ADDR(LCL_VAR))").
PrepareDst will have killed assertions already.
SingleAccretion
force-pushed
the
Slimming-Down-OneAsg-Morphing-Upstream
branch
from
October 10, 2022 13:49
fdcfc5b to
2aa8433
Compare
SingleAccretion
marked this pull request as draft
October 10, 2022 19:57
Contributor
Author
Contributor
Author
|
@dotnet/jit-contrib |
SingleAccretion
commented
Oct 31, 2022
| // Arguments: | ||
| // store - The store node | ||
| // | ||
| void Lowering::TryRetypingFloatingPointStoreToIntegerStore(GenTree* store) |
Contributor
Author
There was a problem hiding this comment.
The original retyping was done under MinOpts too, so this follows; there is of course an argument to be made it should not.
jakobbotsch
approved these changes
Nov 8, 2022
Member
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this change is to extract the parts of
fgMorphOneAsgBlockOpthat actually do useful work and delete the rest.To that end:
initobj <primitive>asstind <primitive zero>.fgMorphOneAsgBlockOp: extract the "init block" part to the general block morpher, leave the copy block part as-is (for now).