Skip to content

[release/6.0] Revert banana RID source build changes from arcade#78362

Closed
carlossanlop wants to merge 1 commit into
dotnet:release/6.0from
carlossanlop:RevertBananaSourceBuildChange
Closed

[release/6.0] Revert banana RID source build changes from arcade#78362
carlossanlop wants to merge 1 commit into
dotnet:release/6.0from
carlossanlop:RevertBananaSourceBuildChange

Conversation

@carlossanlop

@carlossanlop carlossanlop commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

I had originally restored these lines in the arcade dependencies update PR with this commit, but a subsequent automated update reverted my commit. Since the CI had already finished with all the concerns resolved, I didn't want to restart the CI, and instead I'm sending this in a separate change.

This was also addressed directly in the arcade repo: dotnet/arcade#11604 but this PR is to unblock us for now. /cc @ayakael

@ghost ghost assigned carlossanlop Nov 15, 2022
@ghost

ghost commented Nov 15, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

ghost commented Nov 15, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

I had originally restored these lines in the arcade dependencies update PR with this commit, but a subsequent automated update reverted my commit. Since the CI had already finished with all the concerns resolved, I didn't want to restart the CI, and instead I'm sending this in a separate change.

This was also addressed directly in the arcade repo: dotnet/arcade#11604 but this PR is to unblock us for now.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: -

@ayakael

ayakael commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

Memory serves, this was removed from #77508 and pushed off to arcade after CIs were green. So I reckon that the currently failing test units are infrastructure issues.

@ayakael

ayakael commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

Could this be merged to unblock dotnet/installer#14816?

@mmitche

mmitche commented Nov 15, 2022

Copy link
Copy Markdown
Member

@carlossanlop The next arcade update (should be about 45 mins away) has this fix. I can trigger it just for runtime.

@carlossanlop

Copy link
Copy Markdown
Contributor Author

@carlossanlop The next arcade update (should be about 45 mins away) has this fix. I can trigger it just for runtime.

That would be awesome, yes.

@carlossanlop

Copy link
Copy Markdown
Contributor Author

Closing in favor of the upcoming arcade update PR.

@carlossanlop
carlossanlop deleted the RevertBananaSourceBuildChange branch November 15, 2022 22:21
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants