Skip to content

[Android] Bump target SDK version in Android manifest - #80923

Merged
simonrozsival merged 7 commits into
dotnet:mainfrom
simonrozsival:android-bump-manifest-target-sdk-version
Jan 24, 2023
Merged

[Android] Bump target SDK version in Android manifest#80923
simonrozsival merged 7 commits into
dotnet:mainfrom
simonrozsival:android-bump-manifest-target-sdk-version

Conversation

@simonrozsival

@simonrozsival simonrozsival commented Jan 20, 2023

Copy link
Copy Markdown
Member

We should run our tests targeting API 31 which is currently the Google Play's requirement.

It will be necessary to use Android SDK 31+ for local builds. The build process will show an error message instructing the developer to install newer build tools it they're out of date. The CI already uses SDK version 33 (dotnet/dotnet-buildtools-prereqs-docker#713).

@ghost

ghost commented Jan 20, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

We should run our tests targeting API 31 which is currently the Google Play's requirement.

Author: simonrozsival
Assignees: -
Labels:

os-android

Milestone: -

@simonrozsival

Copy link
Copy Markdown
Member Author

/azp run runtime-android

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@simonrozsival
simonrozsival force-pushed the android-bump-manifest-target-sdk-version branch from 67a19ba to cd8f5b9 Compare January 23, 2023 13:27
@simonrozsival

Copy link
Copy Markdown
Member Author

/azp run runtime-android

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread docs/workflow/testing/libraries/testing-android.md Outdated
Comment thread docs/workflow/testing/libraries/testing-android.md Outdated
Comment thread src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs Outdated
@simonrozsival

simonrozsival commented Jan 24, 2023

Copy link
Copy Markdown
Member Author

The test System.Net.Security.Tests.CertificateValidationRemoteServer.ConnectWithRevocation_WithCallback(checkRevocation: True) consistently fails on physical devices but passes on emulators after the bump. That's quite interesting. I'm going to disable the test for now.

@simonrozsival

Copy link
Copy Markdown
Member Author

/azp run runtime-android,runtime-androidemulator

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@simonrozsival

Copy link
Copy Markdown
Member Author

The remaining failing tests on Android are related to #80909.

@simonrozsival
simonrozsival marked this pull request as ready for review January 24, 2023 12:42
@simonrozsival
simonrozsival merged commit 828edfb into dotnet:main Jan 24, 2023
@simonrozsival
simonrozsival deleted the android-bump-manifest-target-sdk-version branch January 24, 2023 18:51
@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2023
@fanyang-mono

Copy link
Copy Markdown
Member

/backport to release/7.0-staging

@github-actions github-actions Bot unlocked this conversation Dec 7, 2023
@github-actions

github-actions Bot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/7133508892

@github-actions

github-actions Bot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

@fanyang-mono backporting to release/7.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Set target SDK version
Applying: Update Android docs
Applying: Disable tests that do not pass with target API 31
Applying: Check if the installed Android SDK is up-to-date
error: sha1 information is lacking or useless (src/tasks/AndroidAppBuilder/Templates/AndroidManifest.xml).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Check if the installed Android SDK is up-to-date
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions

github-actions Bot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

@fanyang-mono an error occurred while backporting to release/7.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants