[mono] Fix missing simd mul/div case#81201
Merged
Merged
Conversation
Member
Author
|
https://gist.github.com/radekdoulik/7d27da1693192e16b621f7cd746f2dec has some diffs of good vs bad generated code |
radekdoulik
reviewed
Jan 26, 2023
radekdoulik
left a comment
Member
There was a problem hiding this comment.
LGTM, it might have been disabled by mistake? I am asking in #76642 (review) to find out if there was a reason to disable it.
fanyang-mono
approved these changes
Jan 26, 2023
lewing
marked this pull request as ready for review
January 26, 2023 15:34
Member
Member
|
I verified this PR restores most of the performance in the threaded raytracer compared to net7 |
lambdageek
approved these changes
Jan 26, 2023
This was referenced Jan 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this only the scalar cases emit anything for Vector128 which is key to emit_vector64_vector128_t working properly. This code was removed in the Vector512 changes probably because it needs additional checks on the types.