Fix special sweep issue for workstation - #81248
Merged
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
cshung
marked this pull request as draft
January 26, 2023 23:31
cshung
force-pushed
the
public/wks-special-sweep
branch
2 times, most recently
from
January 27, 2023 17:12
e4db214 to
e3d6003
Compare
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
cshung
force-pushed
the
public/wks-special-sweep
branch
from
March 3, 2023 18:32
e3d6003 to
e624ee6
Compare
cshung
marked this pull request as ready for review
March 3, 2023 20:28
mangod9
approved these changes
Mar 3, 2023
Contributor
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4407955927 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to make sure that if
special_sweep_pis true, then we must not perform compaction, this rule was missed for the workstation GC case, and this PR put that back in.Validation checklist:
None of these validation tests find any crashes, and this change is not expected to have any performance differences.