Skip to content

Microsoft.NETCore.Platforms: fix graph not being updated on pack.#82204

Merged
ViktorHofer merged 1 commit into
dotnet:mainfrom
tmds:rid_update_on_pack
Feb 16, 2023
Merged

Microsoft.NETCore.Platforms: fix graph not being updated on pack.#82204
ViktorHofer merged 1 commit into
dotnet:mainfrom
tmds:rid_update_on_pack

Conversation

@tmds

@tmds tmds commented Feb 15, 2023

Copy link
Copy Markdown
Member

Fixes #82125.

Regressed in #76068.

@ViktorHofer @wfurt ptal.

@ghost ghost added area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member labels Feb 15, 2023
@ghost

ghost commented Feb 15, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #82125.

Regressed in #76068.

@ViktorHofer @wfurt ptal.

Author: tmds
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@build-analysis build-analysis Bot mentioned this pull request Feb 16, 2023
Closed
ViktorHofer
ViktorHofer approved these changes Feb 16, 2023
View reviewed changes

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@ViktorHofer
ViktorHofer merged commit 4f19d17 into dotnet:main Feb 16, 2023
@ViktorHofer

ViktorHofer commented Feb 16, 2023

Copy link
Copy Markdown
Member

Can you please check is 6.0 and 7.0 are also impacted?

@tmds

tmds commented Feb 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Yes, the issue is also on the 7.0 branch. This change can be backported to it.

I need to take a closer look at what happens on the 6.0 branch, some changes were made as well.
In the issue @wfurt mentioned the update works on 6.0.

@wfurt

wfurt commented Feb 16, 2023

Copy link
Copy Markdown
Member

yes, 6.0 was working for me, 7.0 did not. I plan to sync & put up PR for Ubuntu 23 RID. (for 7.0 I just manually backported the changes from 6.0)

@wfurt wfurt mentioned this pull request Feb 17, 2023
Merged
@ViktorHofer

ViktorHofer commented Mar 1, 2023

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

github-actions Bot commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4307289296

@ViktorHofer ViktorHofer mentioned this pull request Mar 1, 2023
Merged
@github-actions github-actions Bot mentioned this pull request Mar 1, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes
@ericstj ericstj Awaiting requested review from ericstj

Assignees

No one assigned

Labels

area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

generation of RID graph no longer works

3 participants

@tmds @ViktorHofer @wfurt