[browser][non-icu] HybridGlobalization change case#84019
Merged
Conversation
ilonatommy
requested review from
kg,
lewing,
pavelsavara and
radical
as code owners
March 28, 2023 12:50
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsImplements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989. Old, icu-based private API: New, non-icu private API: Affected public API (see: tests in
|
ilonatommy
marked this pull request as draft
March 28, 2023 13:55
This was referenced Mar 28, 2023
mkhamoyan
reviewed
Mar 29, 2023
ilonatommy
marked this pull request as ready for review
March 30, 2023 13:47
This was referenced Mar 30, 2023
mkhamoyan
reviewed
Mar 31, 2023
mkhamoyan
reviewed
Mar 31, 2023
mkhamoyan
reviewed
Mar 31, 2023
mkhamoyan
reviewed
Mar 31, 2023
mkhamoyan
reviewed
Mar 31, 2023
mkhamoyan
approved these changes
Mar 31, 2023
This was referenced Mar 31, 2023
kg
reviewed
Apr 3, 2023
kg
reviewed
Apr 3, 2023
kg
reviewed
Apr 3, 2023
kg
reviewed
Apr 3, 2023
kg
reviewed
Apr 3, 2023
kg
approved these changes
Apr 3, 2023
kg
left a comment
Contributor
There was a problem hiding this comment.
Looks good aside from comments
Member
Author
|
I am merging but if there are any new ideas later, feel free to let me know and we will solve them in a follow-up, cc @pavelsavara, @radical. |
pavelsavara
reviewed
Apr 11, 2023
|
|
||
| ### WASM | ||
|
|
||
| For WebAssembly, both on Browser and WASI, we are using Web API instead of some ICU data. |
Member
There was a problem hiding this comment.
There is no Web API in WASI. It probably means that the whole Hybrid Globalization can't be implemented there.
| { | ||
| internal static bool Invariant { get; } = AppContextConfigHelper.GetBooleanConfig("System.Globalization.Invariant", "DOTNET_SYSTEM_GLOBALIZATION_INVARIANT"); | ||
| #if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS | ||
| #if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS || TARGET_BROWSER || TARGET_WASI |
| // static cctor (on Unix) to be preserved when Invariant=false. | ||
| internal static bool Invariant => Settings.Invariant; | ||
| #if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS | ||
| #if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS || TARGET_BROWSER || TARGET_WASI |
This was referenced Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.
Old, icu-based private API:
GlobalizationNative_ChangeCaseNew, non-icu private API:
ChangeCaseInvariantJS,ChangeCaseJS.Affected public API (see: tests in
TextInfoTests.cs):