Skip to content

Fix precondition if HOST_UNIX in ClrVirtualAllocWithinRange()#84023

Merged
jkotas merged 1 commit into
dotnet:mainfrom
k15tfu:fix-issue-83818-precond
Mar 28, 2023
Merged

Fix precondition if HOST_UNIX in ClrVirtualAllocWithinRange()#84023
jkotas merged 1 commit into
dotnet:mainfrom
k15tfu:fix-issue-83818-precond

Conversation

@k15tfu

@k15tfu k15tfu commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Fixes #83818

@k15tfu
k15tfu force-pushed the fix-issue-83818-precond branch from 7395191 to adc5cf1 Compare March 28, 2023 14:41
@k15tfu

k15tfu commented Mar 28, 2023

Copy link
Copy Markdown
Contributor Author

Addresses comments from #83958.

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jkotas

jkotas commented Mar 28, 2023

Copy link
Copy Markdown
Member

The failure is #84010

@jkotas
jkotas merged commit dc75cd8 into dotnet:main Mar 28, 2023
@k15tfu
k15tfu deleted the fix-issue-83818-precond branch March 29, 2023 04:52
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.OutOfMemoryException when allocating jump stub on macOS ARM64

3 participants