Skip to content

Add linker flags to add fixup data to PDBs (#58417)#84099

Merged
agocke merged 1 commit into
dotnet:mainfrom
agocke:port-debugtype
Mar 31, 2023
Merged

Add linker flags to add fixup data to PDBs (#58417)#84099
agocke merged 1 commit into
dotnet:mainfrom
agocke:port-debugtype

Conversation

@agocke

@agocke agocke commented Mar 29, 2023

Copy link
Copy Markdown
Member

Fixup data can assist native debugging tools in providing more accurate data

(cherry picked from commit 4c814fa)

@agocke
Add linker flags to add fixup data to PDBs (dotnet#58417)
cffdb3a 
Fixup data can assist native debugging tools in providing more accurate data

(cherry picked from commit 4c814fa)
@ghost ghost added the area-Infrastructure-coreclr Only use for closed issues label Mar 29, 2023
@ghost ghost assigned agocke Mar 29, 2023
@ghost

ghost commented Mar 29, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixup data can assist native debugging tools in providing more accurate data

(cherry picked from commit 4c814fa)

Author: agocke
Assignees: agocke
Labels:

area-Infrastructure-coreclr
Milestone: -

@agocke

agocke commented Mar 29, 2023

Copy link
Copy Markdown
Member Author

I forgot to port this one to main, so it got stuck in 6.0.

@agocke
agocke requested a review from a team March 29, 2023 22:32
@build-analysis build-analysis Bot mentioned this pull request Mar 30, 2023
Closed
@agocke
agocke merged commit 5eeb91f into dotnet:main Mar 31, 2023
@agocke
agocke deleted the port-debugtype branch March 31, 2023 23:04
@EgorBo EgorBo mentioned this pull request Apr 4, 2023
Open
@agocke

agocke commented Apr 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

/backport to release/7.0

@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Started backporting to 7.0: https://github.com/dotnet/runtime/actions/runs/4612218884

@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

@agocke an error occurred while backporting to 7.0, please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@carlossanlop

carlossanlop commented Apr 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@agocke please backport to release/7.0-staging.

@carlossanlop

carlossanlop commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

BTW the bot ignored your ninja edit from 7.0 to release/7.0 😄

@agocke

agocke commented Apr 5, 2023

Copy link
Copy Markdown
Member Author

/backport to release/7.0-staging

@github-actions

github-actions Bot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4620950126

@github-actions github-actions Bot mentioned this pull request Apr 5, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes
@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@agocke agocke

Labels

area-Infrastructure-coreclr Only use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agocke @carlossanlop @jkoritzinsky @hoyosjs