Implement proper parsing for primitives in config binding gen - #84154
Merged
layomia merged 2 commits intoApr 12, 2023
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #83533.
|
layomia
force-pushed
the
binder-gen-proper-primitive-parsing
branch
from
April 1, 2023 17:22
f553401 to
8326b94
Compare
layomia
force-pushed
the
binder-gen-proper-primitive-parsing
branch
from
April 4, 2023 23:39
8326b94 to
2e52600
Compare
layomia
force-pushed
the
binder-gen-proper-primitive-parsing
branch
from
April 4, 2023 23:45
2e52600 to
0f222cd
Compare
layomia
marked this pull request as ready for review
April 4, 2023 23:46
eerhardt
reviewed
Apr 5, 2023
eerhardt
reviewed
Apr 5, 2023
eerhardt
reviewed
Apr 5, 2023
tarekgh
reviewed
Apr 5, 2023
tarekgh
reviewed
Apr 5, 2023
tarekgh
reviewed
Apr 5, 2023
tarekgh
reviewed
Apr 5, 2023
eiriktsarpalis
approved these changes
Apr 5, 2023
tarekgh
approved these changes
Apr 5, 2023
tarekgh
left a comment
Member
There was a problem hiding this comment.
I left some minor comments, LGTM otherwise.
layomia
force-pushed
the
binder-gen-proper-primitive-parsing
branch
6 times, most recently
from
April 12, 2023 03:47
15facda to
7d2c810
Compare
layomia
force-pushed
the
binder-gen-proper-primitive-parsing
branch
from
April 12, 2023 06:19
7d2c810 to
3d50b85
Compare
This was referenced Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83533.