Add TargetHostName to QuicConnection by rzikm · Pull Request #84976 · dotnet/runtime

rzikm · 2023-04-18T10:43:47Z

Fixes #80508, also ports #82934 and #81631 to System.Net.Quic to unify behavior.

I discovered that we have some inconsistency in TargetHostName on SslStream side, we will report the encoded TargetHost on client side TargetHostName property and in client cert selection callback, but decoded on server side. So I made changes to always store user-provided TargetHost and encode it only for the parts we need it. I also added a SslStream test for cert validation with IDN domain.

Closes #55687 (added tests which exercise IDN in S.N.Q).

Fixes dotnet#80508

ghost · 2023-04-18T10:43:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

rzikm · 2023-04-18T10:48:15Z

/azp run coreclr-libraries outerloop

azure-pipelines · 2023-04-18T10:48:21Z

No pipelines are associated with this pull request.

rzikm · 2023-04-18T10:48:30Z

/azp list

azure-pipelines · 2023-04-18T10:48:36Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-staging runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-android-grpc-client-tests runtime-wasm-libtests runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-tools-tests runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional

rzikm · 2023-04-18T10:49:00Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-04-18T10:49:08Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2023-04-19T07:18:50Z

CI Failures are:

And more outerloop tests, all unrelated (System.Formats.Tar, System.Runtime.Numerics, ...)

rzikm · 2023-04-19T07:19:11Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-04-19T07:19:22Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP

Some comments, but looks good in general, thanks!
BTW, does this also fixes #55687 or is there still something else that needs to be done?

rzikm · 2023-04-20T18:56:11Z

BTW, does this also fixes #55687 or is there still something else that needs to be done?

I think this should close it, MsQuic is actually encoding/decoding punycode for us.

ManickaP

LGTM, thank you!

rzikm · 2023-04-21T09:09:15Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-04-21T09:09:23Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2023-04-22T07:23:49Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-04-22T07:24:00Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2023-04-24T15:55:20Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-04-24T15:55:29Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2023-04-25T07:13:30Z

Known test failures:
❌WasmTestOnBrowser-System.Text.Json.Tests.WorkItemExecution and 1 more hits - #84101
❌System.Text.RegularExpressions.Tests.RegexMatchTests.StressTestDeepNestingOfLoops and 1 more hits - #84323
❌System.Formats.Tar.Tests.WorkItemExecution and 1 more hits - #84101

Test failure System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_NotepadWithContent_withArgumentList(useShellExecute: True) #68246

Newly filed (unrelated to this PR)

[TestFailure] System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourcePublishesAllDataTypes #85290

And many others (wasm and/or unrelated to SslStream/Quic)

wfurt

LGTM

Add TargetHostName to QuicConnection

40bce02

Fixes dotnet#80508

ghost added area-System.Net.Quic new-api-needs-documentation labels Apr 18, 2023

rzikm requested a review from wfurt April 18, 2023 10:44

Make TargetHostName not nullable

d6bd50e

rzikm and others added 3 commits April 18, 2023 12:55

Fix build

40af6e3

Fix build of tests

f34abe2

Fix failing tests

d76cb1e

This was referenced Apr 19, 2023

[wasm] interpreter timeouts when WebSocket closes unexpectedly #84101

Closed

WasmTestOnBrowser-System.Text.Json.Tests.WorkItemExecution timing out #84434

Closed

rzikm requested a review from a team April 19, 2023 07:19

build-analysis Bot mentioned this pull request Apr 19, 2023

CI System.Text.RegularExpressions.Tests failure #84323

Closed

ManickaP reviewed Apr 20, 2023

View reviewed changes

Comment thread src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs Outdated

Comment thread src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs Outdated

Comment thread src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.SslConnectionOptions.cs Outdated

Code review feedback

04dcff6

ManickaP approved these changes Apr 21, 2023

View reviewed changes

rzikm added 4 commits April 21, 2023 10:26

Use unencoded hostname in user-facing properties/params

a5c124b

Fix failing tests

aae6f48

Revert unwanted changes

2fb014a

Add test for IDN cert validation

98b827b

Fix test again

15aa758

Fix trailing dot in hostname

995949a

rzikm requested a review from ManickaP April 25, 2023 06:59

rzikm mentioned this pull request Apr 25, 2023

[TestFailure] System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourcePublishesAllDataTypes #85290

Closed

wfurt approved these changes Apr 25, 2023

View reviewed changes

build-analysis Bot mentioned this pull request Apr 25, 2023

Various WASM timeouts on CI #85304

Closed

rzikm merged commit 25b61f6 into dotnet:main Apr 25, 2023

rzikm mentioned this pull request May 9, 2023

[Test Failure] System.Net.Security.Tests.SslStreamSniTest.UnencodedHostName_ValidatesCertificate on Android #86003

Open

ghost locked as resolved and limited conversation to collaborators May 25, 2023

karelz added this to the 8.0.0 milestone May 27, 2023

Uh oh!

Conversation

rzikm commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 18, 2023

Uh oh!

rzikm commented Apr 18, 2023

Uh oh!

azure-pipelines Bot commented Apr 18, 2023

Uh oh!

rzikm commented Apr 18, 2023

Uh oh!

azure-pipelines Bot commented Apr 18, 2023

Uh oh!

rzikm commented Apr 18, 2023

Uh oh!

azure-pipelines Bot commented Apr 18, 2023

Uh oh!

rzikm commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rzikm commented Apr 19, 2023

Uh oh!

azure-pipelines Bot commented Apr 19, 2023

Uh oh!

ManickaP left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rzikm commented Apr 20, 2023

Uh oh!

ManickaP left a comment

Choose a reason for hiding this comment

Uh oh!

rzikm commented Apr 21, 2023

Uh oh!

azure-pipelines Bot commented Apr 21, 2023

Uh oh!

rzikm commented Apr 22, 2023

Uh oh!

azure-pipelines Bot commented Apr 22, 2023

Uh oh!

rzikm commented Apr 24, 2023

Uh oh!

azure-pipelines Bot commented Apr 24, 2023

Uh oh!

rzikm commented Apr 25, 2023

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rzikm commented Apr 18, 2023 •

edited

Loading

rzikm commented Apr 19, 2023 •

edited

Loading