Add support for types with parameterized ctors to config binder gen#86365
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsThis PR adds initial support for config types that are bound using parameterized ctors, required properties, and/or init-only properties. Needs a follow up to
|
tarekgh
reviewed
May 17, 2023
tarekgh
reviewed
May 17, 2023
tarekgh
reviewed
May 17, 2023
tarekgh
approved these changes
May 17, 2023
tarekgh
left a comment
Member
There was a problem hiding this comment.
Added a couple of comments please address them before merging.
layomia
force-pushed
the
binder-gen-ctors
branch
2 times, most recently
from
May 17, 2023 21:29
8640d25 to
6cd9bf7
Compare
layomia
marked this pull request as draft
May 17, 2023 22:57
Contributor
Author
|
Will request review again after addressing #86365 (comment). |
layomia
force-pushed
the
binder-gen-ctors
branch
2 times, most recently
from
May 25, 2023 11:33
b5bf629 to
3b4c0b6
Compare
layomia
marked this pull request as ready for review
May 25, 2023 11:43
Contributor
Author
|
Implementation is now in sync with reflection; including exception handling, parameter-property binding... PTAL. |
tarekgh
reviewed
May 25, 2023
Member
tarekgh
approved these changes
May 25, 2023
Contributor
Author
Missed that, thanks. It passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for config types that are bound using parameterized ctors, required properties, and/or init-only properties.